[llvm-commits] [llvm] r119922 - in /llvm/trunk: lib/Target/README.txt lib/Transforms/InstCombine/InstCombineCompares.cpp test/Transforms/InstCombine/icmp.ll

[Chris Lattner]

On Nov 22, 2010, at 12:23 AM, Duncan Sands wrote:

> Hi Chris,
> 
>> Thanks for the review!
> 
> now I think about it some more, aren't all the conditions inverted?
> Consider this:
> 
>        // If the LHS is 1 << x, and we know the result is a power of 2 like 8,
>        // then turn "((1 << x)&8) == 0" into "x == 3".
> 
> Shouldn't that be "x != 3" not "x == 3"?  Likewise for the others.

Yeah, you're completely right, fixed in r119988, thanks!

-Chris