[llvm-commits] [PATCH] Object File Library

[Daniel Dunbar]

On Nov 14, 2010, at 2:23 PM, Chris Lattner wrote:

> 
> On Nov 14, 2010, at 1:51 PM, Rafael Espíndola wrote:
> 
>> On 11 November 2010 21:23, Michael Spencer <bigcheesegs at gmail.com> wrote:
>>> Attached are updated patches to be reviewed. I've split them up into
>>> the generic API, the COFF and ELF implementations, tool changes, and
>>> tests.
>> 
>> I hope you don't mind if at some point I move the basic ELF types from
>> lib/Object/ELFObjectFile.cpp to a header file. I would *love* to use
>> them in ELFObjectWriter.cpp :-)
> 
> These enums should end up in include/llvm/Support, just like Dwarf.h and MachO.h etc.

I'm with Michael on this one. I like it much better to put them in a clean layout like llvm/Object. I dislike "kitchen sink" directories like Support/.

 - Daniel

> 
> -Chris
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits