[llvm-commits] [PATCH] Fix lowering of CALLpcrel32 with absolute address (PR8656)

[Rafael Espíndola]

> Alternatively, I could change X86MCCodeEmitter::EmitImmediate(), so that
> immediate operands can generate fixups. (I'd still have to generate an
> MCConstantExpr for the value, since fixups track expressions).
> Do you think this would be better?

There is a FIXME in that code:

   // FIXME: is this right for pc-rel encoding??  Probably need to emit this as
   // a fixup if so.

Looks like the problem you found. Can you check if the attached patch
fixes the problem?

> Thanks,
> - David Meyer

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reloc.patch
Type: application/octet-stream
Size: 2121 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101122/152e26b1/attachment.obj>