[llvm-commits] [llvm] r119978 - /llvm/trunk/lib/MC/ELFObjectWriter.cpp

[Jason Kim]

On Mon, Nov 22, 2010 at 1:02 PM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
>> +      ELFRelocationEntry(uint64_t RelocOffset, int _Index,
>> +                         unsigned _Type, const MCSymbol *_Symbol,
>> +                         uint64_t Addend)
>> +        : r_offset(RelocOffset), Index(_Index), Type(_Type),
>> +          Symbol(_Symbol), r_addend(Addend) {}
>
> Please don't use names starting with _. I know similar names exist
> elsewhere, but names starting with _ are reserved.
>
>> +  if (! HasRelocationAddend) Addend = 0;
>> +  ELFRelocationEntry ERE(RelocOffset, Index, Type, RelocSymbol, Addend);
>
> No space after the !
>
>
>> +  if (! HasRelocationAddend) Addend = 0;
>> +  ELFRelocationEntry ERE(RelocOffset, Index, Type, RelocSymbol, Addend);
>
> Same.
>
> Thanks,
> Rafael
>

All fixed.
Thanks for catching these.

-jason