[llvm-commits] [Review request] test/CodeGen/X86: Add cases for Win64 to 67 tests
Michael Spencer
bigcheesegs at gmail.com
Mon Nov 22 11:23:38 PST 2010
On Mon, Nov 22, 2010 at 2:49 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Hello guys!
>
> llc infers -march=x86-64 as -mtriple=x86_64-(mingw32|win32).
> Then many tests in CodeGen/X86 would fail due to ABI difference
> between AMD64 and Win64.
> (or Win64 codegen's inefficiency)
>
> The principle to rewrite tests is as below;
>
> - Tests should not hide possible win64's behavior.
> They could exclude Win64 when they were obviously nonsense.
> - Tests should not depend on hosts. Win64's failure should be
> detected also on other platforms.
> When a test has -mtriple=x86_64-linux, it should have also
> -mtriple=x86_64-win32.
> - Some tests might be dubious for Win64. I took two cases.
> - Mark them as XFAIL: mingw, win32, to detect when they were fixed.
> - Add *as-is* pattern to tests. You shall know they are really ugly. :D
>
> Guys, please, I would like everyone to help me to brush up my patches.
> Feel free for yourself to commit one when you might be self-approved.
>
> * 0001-test-CodeGen-X86-fold-mul-lohi.ll-FileCheck-ize-and-.patch
>
> Win64 tends to emit "lea (%rip)". I excluded it from win64 tests.
I think this is correct due to how Windows does PIC, but I'm not
totally sure, as I'm not sure what code was generated on Linux before
r43230.
I'll be getting to the other patches later. Thanks for fixing these!
- Michael Spencer
> * 0002-test-CodeGen-X86-red-zone.ll-Add-explicit-mtriple-x8.patch
>
> Win64 doesn't use redzone stuff.
>
> * 0003-test-CodeGen-X86-sse_reload_fold.ll-FileCheck-ize-an.patch
>
> I don't understand what it intends. I am happy if someone explain to me. :)
>
> * 0004-test-CodeGen-X86-store_op_load_fold2.ll-Add-a-test-f.patch
>
> Alignment of 13th member in the struct makes difference.
>
> * 0005-test-CodeGen-X86-v2f32.ll-Fix-missing-tests-and-add-.patch
>
> I re-enabled 3 tests and added *as-is* Win64's patterns.
>
> * 0006-test-CodeGen-X86-Add-the-as-is-pattern-for-Win64.patch
>
> I added *as-is* patterns for Win64. I intend for reviewrs to help to
> reduce their expressions.
>
> * 0007-test-CodeGen-X86-Mark-as-XFAIL-mingw-win32.-They-sho.patch
>
> I thought they could be fixed in future. When one were fixed, "llc
> -mtriple=x86_64-win32" should be added.
>
> * 0008-test-CodeGen-X86-FileCheck-ize-with-relaxed-expressi.patch
>
> Please watch out;
> - Is my FileCheck-izing reasonable?
> - Do relaxed patterns have any faults?
>
> * 0009-test-CodeGen-X86-FileCheck-ize-and-add-the-case-for-.patch
>
> I added "WIN64:"(and similar) expressions to them.
> I wonder it might be reasonable.
>
> * 0010-test-CodeGen-X86-Relax-expressions-for-Win64.patch
>
> They are FileCheck-ized on ToT. I tweaked them with relaxation to
> recognize Win64 ABI.
>
>
> Have a happy testing! ...Takumi
>
>
>
> test/CodeGen/X86/2007-01-08-X86-64-Pointer.ll | 7 ++-
> test/CodeGen/X86/2007-07-18-Vector-Extract.ll | 6 +-
> test/CodeGen/X86/2008-06-13-VolatileLoadStore.ll | 9 ++-
> test/CodeGen/X86/add.ll | 11 ++--
> test/CodeGen/X86/avoid-lea-scale2.ll | 5 +-
> test/CodeGen/X86/bitcast2.ll | 22 ++++++-
> test/CodeGen/X86/break-sse-dep.ll | 15 ++--
> test/CodeGen/X86/byval.ll | 9 ++-
> test/CodeGen/X86/byval2.ll | 39 ++++++++++-
> test/CodeGen/X86/byval3.ll | 42 +++++++++++-
> test/CodeGen/X86/byval4.ll | 42 +++++++++++-
> test/CodeGen/X86/byval5.ll | 42 +++++++++++-
> test/CodeGen/X86/coalescer-commute2.ll | 21 +++++-
> test/CodeGen/X86/codegen-prepare-extload.ll | 5 +-
> test/CodeGen/X86/constant-pool-remat-0.ll | 35 +++++++++-
> test/CodeGen/X86/constant-pool-sharing.ll | 7 +-
> test/CodeGen/X86/convert-2-addr-3-addr-inc64.ll | 12 +++-
> test/CodeGen/X86/fast-isel-cmp-branch.ll | 7 +-
> test/CodeGen/X86/fast-isel-gep.ll | 11 ++--
> test/CodeGen/X86/fold-mul-lohi.ll | 5 +-
> test/CodeGen/X86/gather-addresses.ll | 23 ++++---
> test/CodeGen/X86/h-register-store.ll | 32 +++++++--
> test/CodeGen/X86/h-registers-0.ll | 24 +++++++-
> test/CodeGen/X86/i128-ret.ll | 6 +-
> test/CodeGen/X86/i64-mem-copy.ll | 8 ++-
> test/CodeGen/X86/iabs.ll | 8 ++-
> test/CodeGen/X86/lea-3.ll | 15 +++--
> test/CodeGen/X86/lea.ll | 9 ++-
> test/CodeGen/X86/lsr-overflow.ll | 5 +-
> test/CodeGen/X86/lsr-reuse-trunc.ll | 9 ++-
> test/CodeGen/X86/masked-iv-safe.ll | 43 ++++++++++---
> test/CodeGen/X86/memcmp.ll | 21 +++---
> test/CodeGen/X86/mmx-copy-gprs.ll | 10 ++-
> test/CodeGen/X86/movgs.ll | 7 +-
> test/CodeGen/X86/optimize-max-3.ll | 11 ++--
> test/CodeGen/X86/peep-vector-extract-concat.ll | 11 +++-
> test/CodeGen/X86/pmulld.ll | 12 +++-
> test/CodeGen/X86/red-zone.ll | 2 +-
> test/CodeGen/X86/red-zone2.ll | 11 ++-
> test/CodeGen/X86/remat-mov-0.ll | 15 ++--
> test/CodeGen/X86/scalar-min-max-fill-operand.ll | 34 +++++++++-
> test/CodeGen/X86/select-aggregate.ll | 7 +-
> test/CodeGen/X86/sse-align-0.ll | 25 +++++++-
> test/CodeGen/X86/sse-align-3.ll | 22 ++++++-
> test/CodeGen/X86/sse-align-7.ll | 8 ++-
> test/CodeGen/X86/sse-commute.ll | 12 +++-
> test/CodeGen/X86/sse-minmax.ll | 2 +
> test/CodeGen/X86/sse_reload_fold.ll | 5 +-
> test/CodeGen/X86/stdarg.ll | 16 ++++-
> test/CodeGen/X86/store_op_load_fold2.ll | 9 ++-
> test/CodeGen/X86/stride-nine-with-base-reg.ll | 34 +++++++++-
> test/CodeGen/X86/stride-reuse.ll | 33 +++++++++-
> test/CodeGen/X86/subreg-to-reg-4.ll | 11 +--
> test/CodeGen/X86/tailcallbyval64.ll | 62 ++++++++++++++++-
> test/CodeGen/X86/tailcallstack64.ll | 3 +-
> test/CodeGen/X86/test-shrink.ll | 21 +++---
> test/CodeGen/X86/unknown-location.ll | 5 +-
> test/CodeGen/X86/use-add-flags.ll | 15 ++--
> test/CodeGen/X86/v2f32.ll | 77 ++++++++++++++++++---
> test/CodeGen/X86/vec_cast.ll | 3 +-
> test/CodeGen/X86/vec_set-8.ll | 7 ++-
> test/CodeGen/X86/vec_set-F.ll | 22 +++++-
> test/CodeGen/X86/vec_shuffle-17.ll | 7 ++-
> test/CodeGen/X86/vec_shuffle-37.ll | 5 +-
> test/CodeGen/X86/widen_load-0.ll | 8 ++-
> test/CodeGen/X86/x86-64-malloc.ll | 4 +-
> test/CodeGen/X86/xor.ll | 9 ++-
> 67 files changed, 884 insertions(+), 216 deletions(-)
>
More information about the llvm-commits
mailing list