[llvm-commits] [llvm-gcc-4.2] r119778 - /llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp

[Duncan Sands]

>>>>      TheTarget = TME->createTargetMachine(TargetTriple, FeatureStr);
>>>> +  TheTarget->setMCUseLoc(false);
>>>
>>> shouldn't this only be set on darwin systems?
>>>
>>
>> Probably. I did it unconditionally first for testing (which as good as
>> it looks like the Darwin bots don't have address space randomization
>> enabled and we don't compare clang bootstraps). Do you know how to
>> detect the current darwin version? Since this is llvm-gcc I assume we
>> can do it at compile time with ifdefs, right?
>
> Subtarget->getDarwinVers()
>
> but it currently only exists in the PPC and X86 versions of Subtarget.

I have to wonder why this is being set in the front-end at all.  The
front-end already told LLVM what the sub-target is.  If the (sub)target
can't handle .loc, shouldn't the code generators automatically fall
back to the other method?

Ciao,

Duncan.