[llvm-commits] [llvm] r119747 - /llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp

[Chris Lattner]

On Nov 18, 2010, at 1:50 PM, Bill Wendling wrote:

> @@ -350,11 +343,10 @@
>       Kind = SPRRegisterList;
> 
>     ARMOperand *Op = new ARMOperand(Kind);
> -    Op->RegList.Registers = new SmallVector<unsigned, 32>();
>     for (SmallVectorImpl<std::pair<unsigned, SMLoc> >::const_iterator
>            I = Regs.begin(), E = Regs.end(); I != E; ++I)
> -      Op->RegList.Registers->push_back(I->first);
> -    std::sort(Op->RegList.Registers->begin(), Op->RegList.Registers->end());
> +      Op->Registers.push_back(I->first);
> +    std::sort(Op->Registers.begin(), Op->Registers.end());

Hey bill,

I see that it's not new in this patch, but please use array_pod_sort in STLExtras.h if the reglist is known-contiguous.

-Chris