[llvm-commits] [llvm-testresults] [llvm] r119600 - /llvm/trunk/unittests/VMCore/ValueMapTest.cpp

[Francois Pichet]

On Wed, Nov 17, 2010 at 9:50 PM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> I saw it was reverted in r119606.
>
> I have two-way patches. Which(either of two) can we take?
> Confirmed on CentOS5, VS8 and VS10.
>
>
> * 0001-unittests-CMakeLists.txt-Suppress-building-ValueMapT.patch
>
> unittests/CMakeLists.txt: Suppress building ValueMapTest on MSC older than 2010.
>
> It seems VS8 and VS9 do not accept *valid* syntax.
>
>
> * 0002-unittests-VMCore-ValueMapTest.cpp-Workaround-It-was-.patch
>
> unittests/VMCore/ValueMapTest.cpp: Workaround: It was the cause of
> syntax error on VS8 and VS9.

I think it would be better and simpler to stop building
ValueMapTest.cpp on MSVC 2008 and lower.

+1 for patch 0001.