[llvm-commits] [llvm-testresults] [llvm] r119600 - /llvm/trunk/unittests/VMCore/ValueMapTest.cpp

NAKAMURA Takumi geek4civic at gmail.com
Wed Nov 17 18:50:30 PST 2010


I saw it was reverted in r119606.

I have two-way patches. Which(either of two) can we take?
Confirmed on CentOS5, VS8 and VS10.


* 0001-unittests-CMakeLists.txt-Suppress-building-ValueMapT.patch

unittests/CMakeLists.txt: Suppress building ValueMapTest on MSC older than 2010.

It seems VS8 and VS9 do not accept *valid* syntax.


* 0002-unittests-VMCore-ValueMapTest.cpp-Workaround-It-was-.patch

unittests/VMCore/ValueMapTest.cpp: Workaround: It was the cause of
syntax error on VS8 and VS9.

It seems older MSVCes do not accept the *right* syntax.


...Takumi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-unittests-CMakeLists.txt-Suppress-building-ValueMapT.patch
Type: application/octet-stream
Size: 1074 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101118/c19791b0/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-unittests-VMCore-ValueMapTest.cpp-Workaround-It-was-.patch
Type: application/octet-stream
Size: 10761 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101118/c19791b0/attachment-0001.obj>


More information about the llvm-commits mailing list