[llvm-commits] [Review request] CMake/MSVS: Support for the target "check"

[Óscar Fuentes]

Hello Takumi.

NAKAMURA Takumi <geek4civic at gmail.com> writes:

> They provide ability to run "check" on Visual Studio IDE with any
> configurations.
> Please take a look into them.
>
> * 0001-test-CMakeLists.txt-Apply-multiple-configurations-on.patch
>
> test/CMakeLists.txt: Apply multiple configurations on Visual Studio
> with clang/test's stuff.

[snip]

> On MSVS8, ${CMAKE_CFG_INTDIR}, aka $(OutDir), has capitalized name(eg.
> Debug), although $(OutDir) is made with lower case(eg. debug).

I don't know much about the testing framework, but I can comment on some
cmake issues:

> +  # Run-time build mode
> +  if(MSVC)
> +    # Expect $(Configuration), $(OutDir), etc.
> +    set(BUILD_MODE "${CMAKE_CFG_INTDIR}")

MSVC is true for nmake builds too (which build type is selected at
configure time, as the rest of makefile-based generators) and I think
you want to restrict the above to the IDE. So change that to

if( MSVC_IDE )

[snip]

Please test the patch with the VS IDE, with VS nmake and with unix
makefiles (on Linux, OS/X or MSYS).