[llvm-commits] [llvm] r119149 - /llvm/trunk/lib/MC/ELFObjectWriter.cpp

[Rafael Espíndola]

> Hmm... If the perf hit becomes measurable, we can pare down the
> virtuals once more ELF targets become MC'ized. Right now, mixing
> nonvirtuals with virtuals for large methods is probably more confusing
> than not (might lead to subtle bugs too). Besides, MCObjectWriter uses
> nonvirtuals only for small leaf methods and virtual for everything
> else, so keeping that logic consistent is good too, I guess.

The issues was not performance, was making the interface unnecessarily
general. Since you are the one most likely to be adding/removing
things from it, its up to you.

>
> Thanks!!
> -jason
>

Cheers,
Rafael