[llvm-commits] [patch] Remove what looks like dead code in the production of debug lines

Devang Patel dpatel at apple.com
Fri Nov 12 10:15:20 PST 2010


On Nov 12, 2010, at 9:06 AM, Rafael EspĂ­ndola wrote:

> The attached patch removes what looks like dead code for the case of
> producing a .debug_line section with no entries. I think it is dead
> because we only emit these tables if we found a line directive.
> 
> The gnu assembler has some strange logic on when it prints data to
> these sections, but if it is forced to print an "empty" .debug_line
> section, it stops after the header:
> 
> readelf -x .debug_line test-as.o
> 
> Hex dump of section '.debug_line':
>  0x00000000 19000000 02001300 00000101 fb0e0d00 ................
>  0x00000010 01010101 00000001 00000100 00       .............
> 
> Which is exactly what we would print with this patch.
> 
> Is it OK?

sure.
-
Devang





More information about the llvm-commits mailing list