[llvm-commits] [llvm] r117322 - in /llvm/trunk: lib/Target/X86/X86ISelLowering.cpp test/CodeGen/X86/stdcall-notailcall.ll

[Chris Lattner]

On Nov 11, 2010, at 4:20 PM, Dale Johannesen wrote:

> 
> On Nov 11, 2010, at 4:12 PMPST, Chris Lattner wrote:
> 
>> 
>> On Oct 26, 2010, at 1:09 AM, Duncan Sands wrote:
>> 
>>> Hi Dale,
>>> 
>>>> --- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
>>>> +++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Mon Oct 25 17:17:05 2010
>>>> @@ -2532,6 +2532,11 @@
>>>>    }
>>>>  }
>>>> 
>>>> +  // An stdcall caller is expected to clean up its arguments; the callee
>>>> +  // isn't going to do that.   PR 8461.
>>> 
>>> I think there's some rule saying that PR numbers should not be mentioned in
>>> code comments (not sure why, but I recall Chris saying this once).
>> 
>> PR #'s should not be used as a substitute for good comments, please make the code be self contained.  Thanks Dale,
> 
> This is not a substitute for comments, as you can see; it is a reference to an example, which I think is useful.  However I'll remove it if you prefer.

Yes please do, so long as there is a testcase in llvm/test that covers this, we should be good.  Thanks!

-Chris