[llvm-commits] [llvm] r116920 - /llvm/trunk/include/llvm/Support/Compiler.h

[Chris Lattner]

On Oct 23, 2010, at 2:20 AM, Chandler Carruth wrote:

> On Wed, Oct 20, 2010 at 5:38 PM, Bill Wendling <wendling at apple.com> wrote:
> On Oct 20, 2010, at 1:44 AM, Chandler Carruth wrote:
> 
>> Author: chandlerc
>> Date: Wed Oct 20 03:44:27 2010
>> New Revision: 116920
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=116920&view=rev
>> Log:
>> Add a comment about ATTRIBUTE_UNUSED to avoid further confusion over when to
>> use it.
>> 
> 
> There's no reason not to use this for variables. And it avoids the void-casting hack.
> 
> Chris expressly asked for the void-cast for variables: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100705/032066.html
> 
> The comment I added was intended to help document this preference. I'll happily change it if you change Chris's mind. ;]

Yep, Chandler is right.  I documented this in the CodingStandards.html file in r118863.  Thanks!

-Chris

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101111/0a7fdbba/attachment.html>