[llvm-commits] [llvm] r117322 - in /llvm/trunk: lib/Target/X86/X86ISelLowering.cpp test/CodeGen/X86/stdcall-notailcall.ll

[Chris Lattner]

On Oct 26, 2010, at 1:09 AM, Duncan Sands wrote:

> Hi Dale,
> 
>> --- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
>> +++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Mon Oct 25 17:17:05 2010
>> @@ -2532,6 +2532,11 @@
>>      }
>>    }
>> 
>> +  // An stdcall caller is expected to clean up its arguments; the callee
>> +  // isn't going to do that.   PR 8461.
> 
> I think there's some rule saying that PR numbers should not be mentioned in
> code comments (not sure why, but I recall Chris saying this once).

PR #'s should not be used as a substitute for good comments, please make the code be self contained.  Thanks Dale,

-Chris