[llvm-commits] [PATCH] elfobjectwriter patch (ARM/MC/ELF)

[Renato Golin]

On 10/11/10 17:57, Jason Kim wrote:
> tryA: move the functionality of the ELFObjectWriterImpl class into
> ELFObjectWriter, and subclass ELFObjectWriter to
> <ARCH>ELFObjectWriter.
 >
(...)
>
> tryB: subclass ELFObjectWriterImpl instead - I am still working out
> the details on this one - but as of right now, it is just as complex
> as the tryA case.

I'm not an expert in MC, but I can't see anything wrong with neither
approaches. The second one seems less invasive, but has the problems you
mentioned.

As MachO and ELF are very different, I can't see now the big problem of
conceptually separating them.

As far as I could gather, you only moved things around, so no problems
for ARM. In this sense, I'm happy with both patches.

cheers,
--renato

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.