[llvm-commits] [llvm] r118660 - in /llvm/trunk: include/llvm/Analysis/AliasAnalysis.h lib/Analysis/AliasAnalysis.cpp lib/Analysis/BasicAliasAnalysis.cpp lib/Analysis/IPA/GlobalsModRef.cpp lib/Analysis/TypeBasedAliasAnalysis.cpp lib/Transforms/IPO/FunctionAttrs.cpp test/Transforms/FunctionAttrs/2008-09-03-ReadNone.ll test/Transforms/FunctionAttrs/2008-09-03-ReadOnly.ll

[Duncan Sands]

Hi Dan,

> --- llvm/trunk/include/llvm/Analysis/AliasAnalysis.h (original)
> +++ llvm/trunk/include/llvm/Analysis/AliasAnalysis.h Tue Nov  9 19:02:18 2010
> @@ -175,6 +175,9 @@
>     ///
>     enum ModRefResult { NoModRef = 0, Ref = 1, Mod = 2, ModRef = 3 };
>
> +  /// These values define additional bits used to define the
> +  /// ModRefBehavior values.
> +  enum { Nowhere = 0, ArgumentPointees = 4, Anywhere = 8 | ArgumentPointees };

how about adding some accessors for extracting the location and modref parts?

> +        if (!(MRB&  AliasAnalysis::Anywhere&
> +              ~AliasAnalysis::ArgumentPointees)) {

That would make this kind of thing ^ more readable.

Ciao,

Duncan.