[llvm-commits] [llvm] r118640 - /llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp

[Bill Wendling]

On Nov 9, 2010, at 3:25 PM, Jim Grosbach wrote:

> Hi Bill,
> 
> Looking good. How close are we to parsing LDM instructions with this in place?
> 
Pretty close. I need to look up-stream from here. We can *parse* them, but can't do much with the information at this point. :)

> On Nov 9, 2010, at 2:44 PM, Bill Wendling wrote:
> 
>>    struct {
>> -      unsigned RegStart;
>> -      unsigned Number;
>> +      std::vector<unsigned> *Registers;
>>    } RegList;
> 
> SmallVector.

Done.

> Also, no need for the struct container.
> 
No, but containers are used in all of the other structures in this union, even if they have only one field. At least it's consistent. :-)

-bw