[llvm-commits] [llvm] r118588 - /llvm/trunk/lib/VMCore/Attributes.cpp

[Owen Anderson]

Author: resistor
Date: Tue Nov  9 11:46:38 2010
New Revision: 118588

URL: http://llvm.org/viewvc/llvm-project?rev=118588&view=rev
Log:
Really fix the leak in the attributes list.  Thanks to Benjamin Kramer for pointing out how I was being stupid.

Modified:
    llvm/trunk/lib/VMCore/Attributes.cpp

Modified: llvm/trunk/lib/VMCore/Attributes.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/Attributes.cpp?rev=118588&r1=118587&r2=118588&view=diff
==============================================================================
--- llvm/trunk/lib/VMCore/Attributes.cpp (original)
+++ llvm/trunk/lib/VMCore/Attributes.cpp Tue Nov  9 11:46:38 2010
@@ -131,8 +131,8 @@
   }
   void DropRef() {
     sys::SmartScopedLock<true> Lock(*ALMutex);
-    sys::cas_flag old = RefCount++;
-    if (old == 1)
+    sys::cas_flag new_val = RefCount--;
+    if (new_val == 0)
       delete this;
   }