[llvm-commits] [PATCH] Tests for inline asm mult-alt constraint selection - LLVM side

[Dale Johannesen]

On Nov 2, 2010, at 12:23 PMPDT, John Thompson wrote:

> I've been sitting on some new test files that just check to make sure llc doesn't abort when it sees the covered subsets of constraints.
>  
> Should I check them in?
>  
> I didn't want to check them in with the main changes, as I had a small worry that the behavior might be different on other platforms.  I've run these successfully on Win32 and a Linux x86 64-bit system.  Is there a possibility that these might behave differently on other platforms?

Sure, but the only way to find out what the behavior is on systems you don't have is to check something in:(  Go ahead, but keep an eye on the regression testers.  Most portability problems of this sort can be fixed by using -mtriple instead of -march.

You might want to strip the metadata first, as I don't think that has anything to do with what you're testing.

> This (plus a clang-side patch I just posted), should be the last of the mult-alt stuff for me for now (barring any problems that come up), as I'm moving on to other Clang areas.
> -John
> 
> -- 
> John Thompson
> John.Thompson.JTSoftware at gmail.com
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101102/9cb69c72/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvmmultalt19.patch
Type: application/octet-stream
Size: 96743 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101102/9cb69c72/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101102/9cb69c72/attachment-0001.html>