[llvm-commits] [llvm] r117596 - /llvm/trunk/lib/System/Unix/Program.inc

[Mikhail Glushenkov]

Hi,

On Tue, Nov 02, 2010 at 11:04:27AM -0700, Dan Gohman wrote:
>
> >  4. Make FindExecutable() always return an executable path, as it used to.
>
>
> FindExecutable shouldn't do this. If LLVM tools are installed with .exe
> suffixes on Windows, FindExecutable should unconditionally append the
> GetEXESuffix string and return the resulting path.
>
> FindExecutable is used when one LLVM tool wants to invoke another LLVM
> tool. These tools are installed together, so they shouldn't have to do
> any checking to figure out how to locate each other. Also, it's rare
> for these tools to be missing, much less present but non-executable.
> Client code is expected to check for errors after an execute anyway, so
> doing extra checking up front is redundant and makes the code harder
> to follow.

I've applied my patches (with your suggested changes). I also removed the
executability check from FindExecutable.

The only thing I'm not very happy with is the name of FindExecutable - it's not
obvious that this function can return a non-executable path.

--
()  ascii ribbon campaign - against html e-mail
/\  www.asciiribbon.org   - against proprietary attachments