[llvm-commits] [llvm] r118030 - /llvm/trunk/lib/VMCore/InlineAsm.cpp

[Dale Johannesen]

Author: johannes
Date: Tue Nov  2 12:59:27 2010
New Revision: 118030

URL: http://llvm.org/viewvc/llvm-project?rev=118030&view=rev
Log:
Apply patch for use-after-free in InlineAsm constant handling,
PR 8522 / 8616046.  Test reduction, analysis and patch by Tim Deegan!
(However, review by someone who understands the classes here better
is welcome.  John Krum will return!)


Modified:
    llvm/trunk/lib/VMCore/InlineAsm.cpp

Modified: llvm/trunk/lib/VMCore/InlineAsm.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/InlineAsm.cpp?rev=118030&r1=118029&r2=118030&view=diff
==============================================================================
--- llvm/trunk/lib/VMCore/InlineAsm.cpp (original)
+++ llvm/trunk/lib/VMCore/InlineAsm.cpp Tue Nov  2 12:59:27 2010
@@ -47,6 +47,7 @@
 }
 
 void InlineAsm::destroyConstant() {
+  getRawType()->getContext().pImpl->InlineAsms.remove(this);
   delete this;
 }