[llvm-commits] [PATCH] MCFragments Clean Up
Rafael Espíndola
rafael.espindola at gmail.com
Mon Nov 1 14:04:50 PDT 2010
> http://codereview.chromium.org/4204007/diff/1/2 (MCAssembler.h)
> http://codereview.chromium.org/4204007/diff/1/3 (MCAssembler.cpp)
+ // Compute fragment size
+ // ComputeSize() may call getFragmentOffset(), so mark F valid,
+ // but leave EffectiveSize invalid to catch errorneous calls to
+ // getFragmentEffectiveSize(
This is better than having PendingLayout, but still think it is better
to just pass StartAddress down as I did in my patch. Have you found
any problems with that approach?
> Thanks,
> David Meyer
Cheers,
Rafael
More information about the llvm-commits
mailing list