[llvm-commits] [llvm] r117755 - in /llvm/trunk: Makefile.config.in autoconf/configure.ac configure tools/CMakeLists.txt tools/Makefile

[Tobias Grosser]

On 10/30/2010 12:28 PM, Dan Gohman wrote:
>
> On Oct 29, 2010, at 5:54 PM, Tobias Grosser wrote:
>>
>> --- llvm/trunk/autoconf/configure.ac (original)
>> +++ llvm/trunk/autoconf/configure.ac Fri Oct 29 19:54:26 2010
>> @@ -121,6 +121,26 @@
>> fi
>> done
>>
>> +dnl Disable the build of polly, even if it is checked out into
>> tools/polly.
>> +AC_ARG_ENABLE(polly,
>> + AS_HELP_STRING([--enable-polly],
>> + [Use polly if available (default is YES)]),,
>> + enableval=default)
>> +case "$enableval" in
>> + yes) AC_SUBST(ENABLE_POLLY,[1]) ;;
>> + no) AC_SUBST(ENABLE_POLLY,[0]) ;;
>> + default) AC_SUBST(ENABLE_POLLY,[1]) ;;
>> + *) AC_MSG_ERROR([Invalid setting for --enable-polly. Use "yes" or
>> "no"]) ;;
>> +esac
>> +
>> +
>> +dnl Check if polly is checked out into tools/polly and configure it if
>> +dnl available.
>> +if (test -d ${srcdir}/tools/polly) && (test $ENABLE_POLLY -eq 1) ; then
>> + AC_SUBST(LLVM_HAS_POLLY,1)
>> + AC_CONFIG_SUBDIRS([tools/polly])
>> +fi
>
> Hi Tobias and ether,
>
> Instead of a configure-time check, can polly just use the
> OPTIONAL_PARALLEL_DIRS
> mechanism? This is what clang uses for what sounds like the same
> purpose; see
> tools/Makefile.

Hi Dan,

I checked if this is possible, but it seems OPTIONAL_PARALLEL_DIRS is a 
Makefile only thing. I currently have no idea how I can use this to 
recursively call polly's configure.
I think clang does not need any additional libraries and seems to reuse 
LLVM's configure, while polly needs its own configure to detect the 
isl/cloog/openscop libraries.
I will investigate, if there is a way to call polly's configure just 
using OPTIONAL_PARALLEL_DIRS.

Suggestions are highly welcome.

Cheers
Tobi