[llvm-commits] [llvm] r117646 - /llvm/trunk/unittests/CMakeLists.txt

NAKAMURA Takumi geek4civic at gmail.com
Sat Oct 30 08:58:35 PDT 2010

Good midnight, Óscar.

> On which platform/compiler the link fails?

I met this issue on x86_64-linux CentOS5 gcc-4.4.
After the last commit, I found the issue closed.

  Bug 8428 - Unable to link JITTests

With my change, I confirmed msvs8, msvs10 and mingw builds are not broken.
Lemme know if I broke anything.

> Unless it was changed on the
> last days, the config&make build sets REQUIRE_RTTI.

Excuse me, I don't understand what you say exactly.
The facts I know;

  - unittests/Makefile and unittests/Makefile.unittests does not require RTTI.
    (utils/unittest requires, I know)
  - To revert your r116682 and my r117646, unittests are built successfully.

> Doing otherwise on
> the cmake build requires a commentary on the CMakeLists.txt file.

I think my change is a simple fixup. I was sorry not to fill the last
commit log better.
And I think it would not be needed to put comments especially unless
it does different that Makefile does.

Anyway I am working on unittests/cmake.
Please be patient, thank you.


More information about the llvm-commits mailing list