[llvm-commits] [llvm] r117665 - /llvm/trunk/lib/Support/GraphWriter.cpp

Dan Gohman gohman at apple.com
Fri Oct 29 10:03:41 PDT 2010


Author: djg
Date: Fri Oct 29 12:03:40 2010
New Revision: 117665

URL: http://llvm.org/viewvc/llvm-project?rev=117665&view=rev
Log:
Fix these error messages to be less confusing. These error
messages primarily indicate errors running the viewer, not
errors with the graph file itself.

Modified:
    llvm/trunk/lib/Support/GraphWriter.cpp

Modified: llvm/trunk/lib/Support/GraphWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/GraphWriter.cpp?rev=117665&r1=117664&r2=117665&view=diff
==============================================================================
--- llvm/trunk/lib/Support/GraphWriter.cpp (original)
+++ llvm/trunk/lib/Support/GraphWriter.cpp Fri Oct 29 12:03:40 2010
@@ -64,8 +64,7 @@
   
   errs() << "Running 'Graphviz' program... ";
   if (sys::Program::ExecuteAndWait(Graphviz, &args[0],0,0,0,0,&ErrMsg)) {
-    errs() << "Error viewing graph " << Filename.str() << ": " << ErrMsg
-           << "\n";
+    errs() << "Error: " << ErrMsg << "\n";
     return;
   }
   Filename.eraseFromDisk();
@@ -90,8 +89,7 @@
   errs() << "Running 'xdot.py' program... ";
   if (sys::Program::ExecuteAndWait(sys::Path(LLVM_PATH_XDOT_PY),
                                    &args[0],0,0,0,0,&ErrMsg)) {
-    errs() << "Error viewing graph " << Filename.str() << ": " << ErrMsg
-           << "\n";
+    errs() << "Error: " << ErrMsg << "\n";
     return;
   }
   Filename.eraseFromDisk();
@@ -156,8 +154,7 @@
   errs() << "Running '" << prog.str() << "' program... ";
 
   if (sys::Program::ExecuteAndWait(prog, &args[0], 0, 0, 0, 0, &ErrMsg)) {
-     errs() << "Error viewing graph " << Filename.str() << ": '"
-            << ErrMsg << "\n";
+    errs() << "Error: " << ErrMsg << "\n";
     return;
   }
   errs() << " done. \n";
@@ -172,7 +169,7 @@
   ErrMsg.clear();
   if (wait) {
      if (sys::Program::ExecuteAndWait(gv, &args[0],0,0,0,0,&ErrMsg))
-        errs() << "Error viewing graph: " << ErrMsg << "\n";
+        errs() << "Error: " << ErrMsg << "\n";
      Filename.eraseFromDisk();
      PSFilename.eraseFromDisk();
   }
@@ -191,8 +188,7 @@
   
   errs() << "Running 'dotty' program... ";
   if (sys::Program::ExecuteAndWait(dotty, &args[0],0,0,0,0,&ErrMsg)) {
-     errs() << "Error viewing graph " << Filename.str() << ": "
-            << ErrMsg << "\n";
+     errs() << "Error: " << ErrMsg << "\n";
   } else {
 // Dotty spawns another app and doesn't wait until it returns
 #if defined (__MINGW32__) || defined (_WINDOWS)





More information about the llvm-commits mailing list