[llvm-commits] [llvm] r117658 - /llvm/trunk/tools/bugpoint/OptimizerDriver.cpp

Dan Gohman gohman at apple.com
Fri Oct 29 09:18:27 PDT 2010


Author: djg
Date: Fri Oct 29 11:18:26 2010
New Revision: 117658

URL: http://llvm.org/viewvc/llvm-project?rev=117658&view=rev
Log:
Check for (unlikely) errors from FindExecutable.

Modified:
    llvm/trunk/tools/bugpoint/OptimizerDriver.cpp

Modified: llvm/trunk/tools/bugpoint/OptimizerDriver.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/bugpoint/OptimizerDriver.cpp?rev=117658&r1=117657&r2=117658&view=diff
==============================================================================
--- llvm/trunk/tools/bugpoint/OptimizerDriver.cpp (original)
+++ llvm/trunk/tools/bugpoint/OptimizerDriver.cpp Fri Oct 29 11:18:26 2010
@@ -143,11 +143,18 @@
     InFile.os().clear_error();
     return 1;
   }
+
+  sys::Path tool = FindExecutable("opt", getToolName(), (void*)"opt");
+  if (tool.empty()) {
+    errs() << "Cannot find `opt' in executable directory!\n";
+    return 1;
+  }
+
+  // Ok, everything that could go wrong before running opt is done.
   InFile.keep();
 
   // setup the child process' arguments
   SmallVector<const char*, 8> Args;
-  sys::Path tool = FindExecutable("opt", getToolName(), (void*)"opt");
   std::string Opt = tool.str();
   if (UseValgrind) {
     Args.push_back("valgrind");





More information about the llvm-commits mailing list