[llvm-commits] [PATCH] MCFragments Clean Up

David Meyer pdox at google.com
Thu Oct 28 17:56:22 PDT 2010

Hi Dan and Rafael,

Sorry for my silence. I was under the weather for a while. As Rafael
suggested, I have broken the patch into smaller parts. Attached is the first
part, which removes MCAssembler::ComputeFragmentSize() and replaces it with
a virtual method MCFragment::ComputeSize().

Special note: In MCAssembler.cpp there is a block of code removed
(ComputeFragmentSize(), 64 lines) and a block of code added (6 ComputeSize()
implementations, 49 lines). The new block should have the same exact
functionality as the old block.

Visual representation is available at:

http://codereview.chromium.org/4204007/diff/1/2  (MCAssembler.h)
http://codereview.chromium.org/4204007/diff/1/3  (MCAssembler.cpp)

  David Meyer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101028/bdecaad8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mcfragment-computesize.patch
Type: text/x-patch
Size: 8122 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101028/bdecaad8/attachment.bin>

More information about the llvm-commits mailing list