[llvm-commits] [PATCH] Inline asm mult-alt constraints done for now

Dale Johannesen dalej at apple.com
Thu Oct 28 15:14:55 PDT 2010

This is responding to your Oct 25 message, sorry I've been slow.
I think this version can go in, given it doesn't break anything.
A few comments:

> +  X86TargetLowering::getSingleConstraintMatchWeight(
> ...
> +  case 'f':
> +  case 't':
> +  case 'u':
> +      if (type->isX86_FP80Ty())

I think all floating point types are OK here.

> +  case 'x':
> +  case 'Y':
> +    if (type->isVectorTy() && type->isFloatingPointTy())

SSE vectors are not floating point.  I think the right thing is to check for size 128.  Also, for MMX, SSE and x87 you should check the right Subtarget flag is set.

There are probably going to be more adjustments necessary in here, this is just offhand.

> +PPCTargetLowering::getSingleConstraintMatchWeight(
> ...
> +  case 'r':

Get rid of this, target independent.

More information about the llvm-commits mailing list