[llvm-commits] [llvm] r117553 - in /llvm/trunk: lib/MC/MCParser/AsmParser.cpp test/MC/AsmParser/directive_set.s

[Chris Lattner]

On Oct 28, 2010, at 9:22 AM, Roman Divacky wrote:

> Author: rdivacky
> Date: Thu Oct 28 11:22:58 2010
> New Revision: 117553
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=117553&view=rev
> Log:
> Implement .equ directive as a synonym to .set.

Looks great, one minor nit pick:

> 
>   if (ParseIdentifier(Name))
> -    return TokError("expected identifier after '.set' directive");
> +    return TokError("expected identifier after '" + Twine(IDVal.str()) + "'");
> 
>   if (getLexer().isNot(AsmToken::Comma))
> -    return TokError("unexpected token in '.set'");
> +    return TokError("unexpected token in '" + Twine(IDVal.str()) + "'");
>   Lex();

These can just use Twine(IDVal), no need to convert to std::string.

-Chris