[llvm-commits] [llvm] r117514 - in /llvm/trunk: lib/Target/X86/X86InstrSSE.td test/CodeGen/X86/avx-intrinsics-x86.ll test/CodeGen/X86/avx-intrinsics-x86_64.ll

Bruno Cardoso Lopes bruno.cardoso at gmail.com
Thu Oct 28 08:42:09 PDT 2010


Seems ok to me! :)

On Wed, Oct 27, 2010 at 10:35 PM, Dale Johannesen <dalej at apple.com> wrote:
> Author: johannes
> Date: Wed Oct 27 19:35:54 2010
> New Revision: 117514
>
> URL: http://llvm.org/viewvc/llvm-project?rev=117514&view=rev
> Log:
> Fix pastos in handling of AVX cvttsd2si, PR8491.
> Bruno, please review, but I'm pretty sure this is right.
> Patch by Alex Mac!
>
>
> Modified:
>    llvm/trunk/lib/Target/X86/X86InstrSSE.td
>    llvm/trunk/test/CodeGen/X86/avx-intrinsics-x86.ll
>    llvm/trunk/test/CodeGen/X86/avx-intrinsics-x86_64.ll
>
> Modified: llvm/trunk/lib/Target/X86/X86InstrSSE.td
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrSSE.td?rev=117514&r1=117513&r2=117514&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86InstrSSE.td (original)
> +++ llvm/trunk/lib/Target/X86/X86InstrSSE.td Wed Oct 27 19:35:54 2010
> @@ -654,10 +654,10 @@
>                                     int_x86_sse_cvttss2si64, f32mem, load,
>                                     "cvttss2si">, XS, VEX, VEX_W;
>  defm Int_VCVTTSD2SI : sse12_cvt_sint<0x2C, VR128, GR32, int_x86_sse2_cvttsd2si,
> -                                    f128mem, load, "cvttss2si">, XD, VEX;
> +                                    f128mem, load, "cvttsd2si">, XD, VEX;
>  defm Int_VCVTTSD2SI64 : sse12_cvt_sint<0x2C, VR128, GR64,
>                                     int_x86_sse2_cvttsd2si64, f128mem, load,
> -                                    "cvttss2si">, XD, VEX, VEX_W;
> +                                    "cvttsd2si">, XD, VEX, VEX_W;
>  }
>  defm Int_CVTTSS2SI : sse12_cvt_sint<0x2C, VR128, GR32, int_x86_sse_cvttss2si,
>                                     f32mem, load, "cvttss2si">, XS;
> @@ -665,10 +665,10 @@
>                                     int_x86_sse_cvttss2si64, f32mem, load,
>                                     "cvttss2si{q}">, XS, REX_W;
>  defm Int_CVTTSD2SI : sse12_cvt_sint<0x2C, VR128, GR32, int_x86_sse2_cvttsd2si,
> -                                    f128mem, load, "cvttss2si">, XD;
> +                                    f128mem, load, "cvttsd2si">, XD;
>  defm Int_CVTTSD2SI64 : sse12_cvt_sint<0x2C, VR128, GR64,
>                                     int_x86_sse2_cvttsd2si64, f128mem, load,
> -                                    "cvttss2si{q}">, XD, REX_W;
> +                                    "cvttsd2si{q}">, XD, REX_W;
>
>  let isAsmParserOnly = 1, Pattern = []<dag> in {
>  defm VCVTSS2SI   : sse12_cvt_s<0x2D, FR32, GR32, undef, f32mem, load,
>
> Modified: llvm/trunk/test/CodeGen/X86/avx-intrinsics-x86.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/avx-intrinsics-x86.ll?rev=117514&r1=117513&r2=117514&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/avx-intrinsics-x86.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/avx-intrinsics-x86.ll Wed Oct 27 19:35:54 2010
> @@ -230,7 +230,7 @@
>
>
>  define i32 @test_x86_sse2_cvttsd2si(<2 x double> %a0) {
> -  ; CHECK: vcvttss2si
> +  ; CHECK: vcvttsd2si
>   %res = call i32 @llvm.x86.sse2.cvttsd2si(<2 x double> %a0) ; <i32> [#uses=1]
>   ret i32 %res
>  }
>
> Modified: llvm/trunk/test/CodeGen/X86/avx-intrinsics-x86_64.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/avx-intrinsics-x86_64.ll?rev=117514&r1=117513&r2=117514&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/avx-intrinsics-x86_64.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/avx-intrinsics-x86_64.ll Wed Oct 27 19:35:54 2010
> @@ -17,7 +17,7 @@
>
>
>  define i64 @test_x86_sse2_cvttsd2si64(<2 x double> %a0) {
> -  ; CHECK: vcvttss2si
> +  ; CHECK: vcvttsd2si
>   %res = call i64 @llvm.x86.sse2.cvttsd2si64(<2 x double> %a0) ; <i64> [#uses=1]
>   ret i64 %res
>  }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc




More information about the llvm-commits mailing list