[llvm-commits] [llvm] r117451 - in /llvm/trunk: lib/MC/ELFObjectWriter.cpp test/MC/ELF/abs.s

[Rafael Espindola]

Author: rafael
Date: Wed Oct 27 11:04:30 2010
New Revision: 117451

URL: http://llvm.org/viewvc/llvm-project?rev=117451&view=rev
Log:
Symbols defined as the difference of other two end up in the ABS section.

Added:
    llvm/trunk/test/MC/ELF/abs.s
Modified:
    llvm/trunk/lib/MC/ELFObjectWriter.cpp

Modified: llvm/trunk/lib/MC/ELFObjectWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/ELFObjectWriter.cpp?rev=117451&r1=117450&r2=117451&view=diff
==============================================================================
--- llvm/trunk/lib/MC/ELFObjectWriter.cpp (original)
+++ llvm/trunk/lib/MC/ELFObjectWriter.cpp Wed Oct 27 11:04:30 2010
@@ -863,7 +863,7 @@
     if (it->isCommon()) {
       assert(!Local);
       MSD.SectionIndex = ELF::SHN_COMMON;
-    } else if (Symbol.isAbsolute()) {
+    } else if (Symbol.isAbsolute() || RefSymbol.isVariable()) {
       MSD.SectionIndex = ELF::SHN_ABS;
     } else if (RefSymbol.isUndefined()) {
       MSD.SectionIndex = ELF::SHN_UNDEF;
@@ -871,11 +871,8 @@
       // are able to set it.
       if (GetBinding(*it) == ELF::STB_LOCAL)
         SetBinding(*it, ELF::STB_GLOBAL);
-    } else if (Symbol.isVariable()) {
-      MSD.SectionIndex = SectionIndexMap.lookup(&RefSymbol.getSection());
-      assert(MSD.SectionIndex && "Invalid section index!");
     } else {
-      MSD.SectionIndex = SectionIndexMap.lookup(&Symbol.getSection());
+      MSD.SectionIndex = SectionIndexMap.lookup(&RefSymbol.getSection());
       assert(MSD.SectionIndex && "Invalid section index!");
     }
 

Added: llvm/trunk/test/MC/ELF/abs.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ELF/abs.s?rev=117451&view=auto
==============================================================================
--- llvm/trunk/test/MC/ELF/abs.s (added)
+++ llvm/trunk/test/MC/ELF/abs.s Wed Oct 27 11:04:30 2010
@@ -0,0 +1,16 @@
+// RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu %s -o - | elf-dump  | FileCheck %s
+
+// Test that zed will be an ABS symbol
+
+.Lfoo:
+.Lbar:
+        zed = .Lfoo - .Lbar
+
+// CHECK:      # Symbol 0x00000001
+// CHECK-NEXT: (('st_name', 0x00000001) # 'zed'
+// CHECK-NEXT:  ('st_bind', 0x00000000)
+// CHECK-NEXT:  ('st_type', 0x00000000)
+// CHECK-NEXT:  ('st_other', 0x00000000)
+// CHECK-NEXT:  ('st_shndx', 0x0000fff1)
+// CHECK-NEXT:  ('st_value', 0x00000000)
+// CHECK-NEXT:  ('st_size', 0x00000000)