[llvm-commits] [llvm] r117323 - /llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp

[Rafael Espindola]

Author: rafael
Date: Mon Oct 25 17:26:55 2010
New Revision: 117323

URL: http://llvm.org/viewvc/llvm-project?rev=117323&view=rev
Log:
Produce the headers directly in the Finish method. This allows us to use
the existing streamer methods that are endian safe.

Modified:
    llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp

Modified: llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp?rev=117323&r1=117322&r2=117323&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp Mon Oct 25 17:26:55 2010
@@ -95,8 +95,6 @@
 
   class ObjectAttributeEmitter : public AttributeEmitter {
     MCObjectStreamer &Streamer;
-    size_t SectionStart;
-    size_t TagStart;
     StringRef CurrentVendor;
     SmallString<64> Contents;
 
@@ -116,20 +114,7 @@
 
       CurrentVendor = Vendor;
 
-      SectionStart = Contents.size();
-
-      // Length of the data for this vendor.
-      Contents.append(4, (char)0);
-
-      Contents.append(Vendor.begin(), Vendor.end());
-      Contents += 0;
-
-      Contents += ARMBuildAttrs::File;
-
-      TagStart = Contents.size();
-
-      // Length of the data for this tag.
-      Contents.append(4, (char)0);
+      assert(Contents.size() == 0);
     }
 
     void EmitAttribute(unsigned Attribute, unsigned Value) {
@@ -139,15 +124,24 @@
     }
 
     void Finish() {
-      size_t EndPos = Contents.size();
+      const size_t ContentsSize = Contents.size();
+
+      // Vendor size + Vendor name + '\0'
+      const size_t VendorHeaderSize = 4 + CurrentVendor.size() + 1;
 
-      // FIXME: endian.
-      *((uint32_t*)&Contents[SectionStart]) = EndPos - SectionStart;
+      // Tag + Tag Size
+      const size_t TagHeaderSize = 1 + 4;
 
-      // +1 since it includes the tag that came before it.
-      *((uint32_t*)&Contents[TagStart]) = EndPos - TagStart + 1;
+      Streamer.EmitIntValue(VendorHeaderSize + TagHeaderSize + ContentsSize, 4);
+      Streamer.EmitBytes(CurrentVendor, 0);
+      Streamer.EmitIntValue(0, 1); // '\0'
+
+      Streamer.EmitIntValue(ARMBuildAttrs::File, 1);
+      Streamer.EmitIntValue(TagHeaderSize + ContentsSize, 4);
 
       Streamer.EmitBytes(Contents, 0);
+
+      Contents.clear();
     }
   };