[llvm-commits] [LLVMdev] Fwd: Fwd: Proof of concept patch for unifying the .s/ELF emission of .ARM.attributes

Rafael Espindola espindola at google.com
Mon Oct 25 10:51:51 PDT 2010

On 25 October 2010 13:21, Jason Kim <jasonwkim at google.com> wrote:
> All well and good, Rafael, 3 new classes and 4 new slots.
> In any case, I am done arguing this - outside of any additional input
> on this might as well as commit your rework. Any objections?

All of them used ;-). The member variable are also in a class that is
only alive inside emitAttributes.

I will commit your patch with the modifications I made.

> On Sun, Oct 24, 2010 at 7:01 PM, Rafael Espíndola
> <rafael.espindola at gmail.com> wrote:
>> I also noticed that we were trying to optimize the output of 41 bytes
>> of data :-)
> Err, Yes. 2+ weeks on this. I am without words at the moment.
>> The attached patch is similar to the previous one but drops the API
>> changes by just accumulating the attributes locally before outputting
>> them.
> -jason

Rafael Ávila de Espíndola

More information about the llvm-commits mailing list