[llvm-commits] [llvm] r117264 - in /llvm/trunk: docs/LangRef.html include/llvm/Attributes.h lib/AsmParser/LLLexer.cpp lib/AsmParser/LLParser.cpp lib/AsmParser/LLToken.h lib/VMCore/Attributes.cpp

Charles Davis cdavis at mymail.mines.edu
Mon Oct 25 09:31:16 PDT 2010

On 10/25/10 9:54 AM, Duncan Sands wrote:
> Hi Charles,
>> +<dt><tt><b>hotpatch</b></tt></dt>
>> +<dd>This attribute indicates that the prologue should contain a 'hotpatch'
>> +      sequence at the beginning. This is the same sequence used in the
>> +      system DLLs in Microsoft Windows XP Service Pack 2 and higher.</dd>
> I think this is too target specific, and describes the implementation of the
> feature rather than the functionality the feature provides.  I think you should
> describe the functionality without saying how it is done, and mention that on
> windows it is compatible with the Microsoft thing.
Done. r117267.


More information about the llvm-commits mailing list