[llvm-commits] [PATCH] Teach CMake to only touch tablegen-generated files if anything actually changed.

Óscar Fuentes ofv at wanadoo.es
Fri Oct 22 10:44:04 PDT 2010


Frits van Bommel <fvbommel at gmail.com> writes:

> On Fri, Oct 22, 2010 at 7:06 PM, Frits van Bommel <fvbommel at gmail.com> wrote:
>> Note that I wasn't sure what COMMENT lines to use for the two
>> different targets, but "Building ${ofn}.tmp..." and "Updating ${ofn}
>> if necessary" seems reasonable. (Similar phrasing is used when
>> regenerating library dependencies, I think)
>
> It appears that if you use COMMENT "" the entire line disappears, so
> we can hide this implementation detail from the user interface.
> Updated patch attached.

Looks good. Committed as 117113.

Time ago I fought quite a bit for solving this problem, and every trick
I tried caused some kind of annoyance elsewhere. Let's hope that your
patch got it right.



More information about the llvm-commits mailing list