[llvm-commits] [llvm] r117057 - in /llvm/trunk: cmake/config-ix.cmake include/llvm/Config/config.h.cmake include/llvm/Support/Endian.h unittests/CMakeLists.txt unittests/Support/EndianTest.cpp

[Óscar Fuentes]

Michael Spencer <bigcheesegs at gmail.com> writes:

>>> Author: mspencer
>>> Date: Thu Oct 21 15:28:21 2010
>>> New Revision: 117057
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=117057&view=rev
>>> Log:
>>> Support: Add Endian.h
>>>
>>> Added:
>>>     llvm/trunk/include/llvm/Support/Endian.h
>>>     llvm/trunk/unittests/Support/EndianTest.cpp
>>> Modified:
>>>     llvm/trunk/cmake/config-ix.cmake
>>>     llvm/trunk/include/llvm/Config/config.h.cmake
>>>     llvm/trunk/unittests/CMakeLists.txt
>>
>> Why this change does not affect the config&make build too?
>>
>> [snip]
>
> Because I think GNU Build already handles it.

I don't think so. If you define a macro in config.h.cmake and not in
config.h.in, you make the builds diverge, which is not a good thing. On
this case you add code that depends on that macro, so the divergence is
clear.

> If not, I have never touched GNU Build, so I would appreciate if
> someone else that knows that monster to add it.

Please make an explicit request on the llvm ml. If this is not
addressed, it may cause confussion on the future. Please note that most
LLVM users and developers use the config&make build, so the code you
added will behave differently for them.