[llvm-commits] [patch] Remember the VariantKind when recursively evaluating a variable

[Michael Spencer]

2010/10/20 Rafael Espíndola <rafael.espindola at gmail.com>:
> This is an update to a patch I posted some time ago. It fixes relocations
> against aliases. Without this patch we would just forget the VariantKind.
>
> Another option is to just not recurse if the variant kind is not
> VK_None. This would match gnu as a bit better, but also requires a
> change to  MCAssembler::EvaluateFixup so that it can handle aliases
> correctly.
>
> Is the patch OK?
>
> Cheers,
> Rafael
>

There's no reason to add the MCContext arguments everywhere. It is
accessible via Layout->getAssembler().getContext()

I don't fully understand the changes to EvaluateAsRelocatableImpl. Are
we just recreating the expression? This looks like a hack to me.

- Michael Spencer