[llvm-commits] [Review request] test: Add the new feature "loadable_module"

NAKAMURA Takumi geek4civic at gmail.com
Thu Oct 21 00:51:57 PDT 2010


Hello.

Cygming can build Module.dll for Opt and Bugpoint with autoconf.

I will propose two patches attached. Please give me comments.


* 0001 - Add the feature "loadable_module"

By default, "loadable_module" is 1.
On cygwin and win32(s), it obeys ENABLE_SHARED.

It should not have any sideeffects, I believe.


* 0002 - patches for 4 tests

Without "loadable_module", all of 4 tests marks as "UNSUPPORTED".

I have confirmed (both enable_shared) on CentOS5, Cygwin and Mingw.

I have confirmed with cmake on Mingw.
IIRC, cmake/mingw and cmake/msvc set ENABLE_SHARED as '0'.
I believe it might not affect msvc buildbots.


ps. LLVMHello.dll can be built manually :)
(or seek llvmdev or here with "llvmhello")


Enjoy happy testing, ...Takumi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-test-Add-the-new-feature-loadable_module.patch
Type: application/octet-stream
Size: 1894 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101021/507ffe6b/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-test-Check-the-feature-loadable_module-.-Now-we-can-.patch
Type: application/octet-stream
Size: 2605 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101021/507ffe6b/attachment-0001.obj>


More information about the llvm-commits mailing list