[llvm-commits] Proof of concept patch for unifying the .s/ELF emission of .ARM.attributes

[Rafael Espíndola]

> Does this make sense? Am I missing something?

Yes. Unnecessary member variables can make the code hard to reason
about. Not as bad as global ones, but similar issue. You are also
missing that some of the variables were *fully* unused or just
initialized to NULL.

The attached patch is a modified version of yours that illustrates
some of the issues.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 12081 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101020/93336aba/attachment.bin>