[llvm-commits] [llvm] r116834 - /llvm/trunk/unittests/CMakeLists.txt

[Óscar Fuentes]

"Michael J. Spencer"
<bigcheesegs at gmail.com> writes:

> Author: mspencer
> Date: Tue Oct 19 13:04:19 2010
> New Revision: 116834
>
> URL: http://llvm.org/viewvc/llvm-project?rev=116834&view=rev
> Log:
> unittests: Use the correct defines and global variables when building on CMake.
>
> Modified:
>     llvm/trunk/unittests/CMakeLists.txt
>
> Modified: llvm/trunk/unittests/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/CMakeLists.txt?rev=116834&r1=116833&r2=116834&view=diff
> ==============================================================================
> --- llvm/trunk/unittests/CMakeLists.txt (original)
> +++ llvm/trunk/unittests/CMakeLists.txt Tue Oct 19 13:04:19 2010
> @@ -13,6 +13,8 @@
>  endfunction()
>  
>  include_directories(${LLVM_MAIN_SRC_DIR}/utils/unittest/googletest/include)
> +set(LLVM_REQUIRES_RTTI 1)
> +add_definitions(-DGTEST_HAS_RTTI=0)

This is not what the corresponding Makefile does. If you must diverge
from the settings on the Makefile's (both on unittests/CMakeLists.txt
and tools/unittests/CMakeLists.txt) please leave a comment explaining
the reason.