[llvm-commits] [PATCH] Fix ARM var-arg bug (bug 8347)

[Evan Cheng]

Looks good. Please commit. Thanks.

Evan

On Oct 15, 2010, at 7:20 AM, David Meyer wrote:

> Hi Evan / Jim,
> 
> For reference, X86-64 does the same thing for var-arg (spill registers upon function entry) and the immutable flag is correctly set to false for the register save area.
> 
> This does limit optimization, but unfortunately it is needed for correctness. (at least, without making other changes to the backend)
> 
> - David M
> 
> On Wed, Oct 13, 2010 at 11:59 AM, Jim Grosbach <grosbach at apple.com> wrote:
> Hi David,
> 
> Your explanation definitely makes sense. Thanks for digging into this. My only hesitation is a, perhaps unfounded, concern that this may be a bit of a big hammer and limit other opportunities that are desirable. Evan, what do you think?
> 
> -Jim
> 
> On Oct 13, 2010, at 10:38 AM, David Meyer wrote:
> 
>> Attached patch resolves this bug:
>> 
>> http://llvm.org/bugs/show_bug.cgi?id=8347
>> 
>> - David M
>> <bugfix8347.patch>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101015/ec9c26eb/attachment.html>