[llvm-commits] [PATCH]: fixing clang Targets.cpp for PPC

[Rafael Espindola]

> I think you're right that the patch should not have all these ifs, so I have
> reformulated the patch (attached). Since Darwin (and maybe AIX? but clang
> does not support that, as far as I know) are the oddball case for PPC32, I
> changed it so PPC32 defaults to the SYSV/ELF ABI, and DarwinPPCTargetInfo
> just overrides it with its own thing. So now there are no more getters and
> setters, nor strcmp().
>
> Thanks for the review and comments.

It is looking a lot better! One thing I noticed is that getBoolWidth
is not virtual in TargetInfo, so this might not have the effect you
are looking for. To be consistent with the rest of TargetInfo what you
probably want is to add member variables to it and have the
constructor set the correct values.

> -Nathan

Cheers,
-- 
Rafael Ávila de Espíndola