[llvm-commits] [PATCH] Inline asm mult-alt constraint selection - incremental change 2

[John Thompson]

Thanks for catching this.  I'll add a check for tabs and line endings as
part of my submission procedure.  I've enclosed an updated patch.

May I check this in?

-John

On Tue, Oct 12, 2010 at 1:32 AM, Frits van Bommel <fvbommel at gmail.com>wrote:

> On Tue, Oct 12, 2010 at 2:16 AM, John Thompson
> <john.thompson.jtsoftware at gmail.com> wrote:
> > Here's an updated patch with some more revisions, adding some missing
> stuff
> > I found while developing new tests for the new stuff.  Still lacking is
> that
> > I also see that the "lowering" operation is missing support for some of
> the
> > x86 constraints I added, which I'll work on next, as well as
> submitting the
> > new tests for this stuff.  But may I check in the current changes, so as
> not
> > to diverge too much from the trunk?  I've successfully run the regression
> > tests, test-suite, and the gcc tests with Clang on Linux 64-bit with the
> > current changes.
>
> You have hard tabs inside "enum ConstraintWeight" (in
> TargetLowering.h, at the top of the patch).
>



-- 
John Thompson
John.Thompson.JTSoftware at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101012/827b0ee7/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvmmultalt12.patch
Type: application/octet-stream
Size: 16374 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101012/827b0ee7/attachment.obj>