[llvm-commits] [llvm] r116056 - in /llvm/trunk: lib/Target/X86/X86ISelLowering.cpp test/CodeGen/X86/win64_params.ll

[Cameron Esfahani]

As far as I can tell, without this patch, the home register stack space isn't getting allocated.  As I mentioned in the commit message, the problem with doing it here is that it's unconditional, when it's only required for non-leaf routines...

On Oct 8, 2010, at 4:34 AM, Anton Korobeynikov wrote:

> Hi Cameron,
> 
>> Small patch to restore home register stack space allocation for the Win64 case.  Add test case.  This code eventually needs to be tighter, since it's always allocating it, even in leaf routines.
> What's about "-40" case? Do we still need it?
> 
> -- 
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State University

Cameron Esfahani
dirty at apple.com

"Americans are very skilled at creating a custom meaning from something that's mass-produced."

Ann Powers