[llvm-commits] [patch] va_arg for X86-64

[David Meyer]

Hi,

Attached is an initial implementation of va_arg for X86-64 (against revision
115912).

It should work for all basic types. I have tested it on Linux only.

This is my first patch, I do not have commit access. I'd appreciate feedback
regarding:

1) Code correctness (of course)
2) Strategies for testing this new feature
3) Whether the default expansion of VAARG is actually suitable for Win64.
4) Whether Darwin and Cygwin follow the same ABI.

Graphical code review is available at:
http://codereview.chromium.org/3533017/show

In a day or two, I plan to send a patch for llvm-gcc which adds a flag to
toggle direct emission of the va_arg() instruction.
(a feature written by Alan Donovan)

Thanks,
 - David M (pdox at google.com)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101007/91c89523/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vaarg-x86-64.patch
Type: application/octet-stream
Size: 19506 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101007/91c89523/attachment.obj>