[llvm-commits] Proof of concept patch for unifying the .s/ELF emission of .ARM.attributes

[Jim Grosbach]

Looks good to me, too, with the extremely minor cleanup of removing trailing whitespace first. Please commit!

-Jim

On Oct 6, 2010, at 3:15 PM, Rafael Espindola wrote:

> On 6 October 2010 17:29, Jason Kim <jasonwkim at google.com> wrote:
>> The patch has been modified to immediately unify .s/ELF emission of
>> .ARM.attributes
>> I am requesting feedback,
> 
> I think the patch is fine.
> 
>> There's more work to be done. the .cpu attribute needs to be turned
>> into an enum for consistency.
> 
> Yes, that can be done in another patch. The "cpu enum" -> text mapping
> then only has to be done when printing assembly.
> 
>> Thanks!
>> -jason
> 
> 
> Thanks,
> -- 
> Rafael Ávila de Espíndola