[llvm-commits] [llvm] r115753 - /llvm/trunk/lib/Linker/LinkModules.cpp

[Bill Wendling]

On Oct 6, 2010, at 11:27 AM, Dan Gohman wrote:

> On Oct 5, 2010, at 11:16 PM, Bill Wendling wrote:
> 
>> --- llvm/trunk/lib/Linker/LinkModules.cpp (original)
>> +++ llvm/trunk/lib/Linker/LinkModules.cpp Wed Oct  6 01:16:30 2010
> [...]
>> +  // The Objective-C __image_info section should be unique.
>> +  if (SrcSec == DstSec &&
>> +      (SrcSec.find("__objc_imageinfo") != StringRef::npos ||
>> +       SrcSec.find("__image_info") != StringRef::npos))
> 
> Hi Bill, magic names, in the LLVM IR linker? If this is the way this will
> be done, can you document this in LangRef.html?
> 
That's where my "polish" comment comes into play. I don't like it either, and I don't think that this is the way to go in the future. This predicate should exist in a centralized place...

-bw