[llvm-commits] [Review request] test: adding triplets and FileCheck-ize for cygming(and msvc)

NAKAMURA Takumi geek4civic at gmail.com
Tue Oct 5 01:28:21 PDT 2010


Good evening, Michael!

I am on the way for rewriting with flexible matching w/o adding triplet.

2010/10/4 Michael Spencer <bigcheesegs at gmail.com>:
>> * 0001(1 file) -mtriple=i686-linux
>>
>>  It was needed for Cygwin and Mingw.
>
> See above, and this test passes for me on pure Windows.

Modified one attached. I got rid of adding triplet.
I reminded this test would not be needed to be @main.
(It is as same that I worked in r112801, twoaddr-coalesce.)

On cygming, @main should have an extra hook, __main.
I know this test should pass w/o modification on msvc.

thanks...Takumi
-------------- next part --------------
commit 1dc941b6a523cbc2ba0a699c0c10235c05bf5127
Author: NAKAMURA Takumi <geek4civic at gmail.com>
Date:   Fri Sep 24 11:44:51 2010 +0900

    test/CodeGen/X86/atomic_op.ll: Rename @main to @func. Extra sequences will be inserted to @main as prologue on cygming, to fail.

diff --git a/test/CodeGen/X86/atomic_op.ll b/test/CodeGen/X86/atomic_op.ll
index 72ff971..84bae46 100644
--- a/test/CodeGen/X86/atomic_op.ll
+++ b/test/CodeGen/X86/atomic_op.ll
@@ -2,7 +2,7 @@
 
 target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128"
 
-define void @main(i32 %argc, i8** %argv) nounwind {
+define void @func(i32 %argc, i8** %argv) nounwind {
 entry:
 	%argc.addr = alloca i32		; <i32*> [#uses=1]
 	%argv.addr = alloca i8**		; <i8***> [#uses=1]


More information about the llvm-commits mailing list