[llvm-commits] [PATCH] Fix broken test on windows.

[Daniel Dunbar]

On Wed, Aug 25, 2010 at 12:48 AM, Michael Spencer <bigcheesegs at gmail.com> wrote:
> This patch fixes a test on windows.
>
> I could not figure out what the problem with the grep line was. I
> could make it work by simply saving the file with VS, but that doesn't
> make any sense because I checkout unix line endings and VS will use
> unix line endings if that's what the file has. There are other tests
> that use this exact same pattern (including the trailing \ and new
> line with grep) that pass on windows.
>
> The FileCheck lines are much clearer anyway (damn TCL). It also
> doesn't include the embedded tab.
>
> I'm posting this for review mainly because I'm not 100% sure the check
> line is correct. I don't get why the %'s were in []'s in the grep
> line. Was that just to make TCL happy?

To be honest, I don't either.

Tcl quoting is so horrible that many developers have no idea how it
works, and end up quoting things left and right that may or may not
need it. So you can rarely infer much from how the Tcl grep line is
actually spelled.

That said, it is also very possible that the 'lit' Tcl lexer/parser has bugs.

Regardless, thanks for converting to FileCheck!

 - Daniel

>
> - Michael Spencer
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>